Ensure that space application supporter can access GET /v3/jobs/:guid #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests that check permissions. - Adjust documentation; "All Roles" are permitted.
sweinstein22
added
the
space-application-supporter
monamohebbi
approved these changes
Jun 10, 2021
sweinstein22
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Ran /v3/jobs/:guid against an environment with the latest CAPI as both a space dev and a space application supporter just to confirm output looked the same without any implementation changes. Confirmed that diff was empty, and manually checked that output looked correct.
$ diff space-app-supporter-job-guid space-dev-job-guid
Code changes and docs changes look good, thanks for the PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2224.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests