Support expiring of DB connections #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some config parameters which (only when provided) enable the connection_expiration extension for Sequel. This allows connections to be closed and recreated after a certain time period (with some random delay to prevent the entire pool being recycled at once). This should help DBs that are suffering from performance issues related to extremely long running connections as the recycling should allow resources associated with those connections to be freed
andy-paine
force-pushed
the
db-connection-expiration
branch
from
0126b9b
to
eba6b1e
Compare
3 tasks
|
Looks good to me, thanks for the PR! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Support DB connections being expired after a certain time period (with a random delay)
An explanation of the use cases your change solves
We have long running CC processes and connections appear to be consuming and not freeing a lot of Postgres resources. We are hoping that by expiring connections after a certain (configurable) time limit, we can free up these resources before we see more damaging effects on the DB
It uses a builtin extension to Sequel which should hopefully be well understood and tested and just exposes some configuration parameters. Additionally, the extension should only end up being enabled for users who opt-in by specifying the timeout and optionally a random delay
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests