Provide pageable users of space endpoint

[moleske]

• /v3/spaces/:guid/users now exists with filters

[#2489]

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

• A short explanation of the proposed change:

• An explanation of the use cases your change solves

• Links to any other associated PRs

• I have reviewed the contributing guide

• I have viewed, signed, and submitted the Contributor License Agreement

• I have made this pull request to the main branch

• I have run all the unit tests using bundle exec rake

• I have run CF Acceptance Tests

@ctlong

[sweinstein22]

Behavior Check

• deployed changes to a bosh lite
• ran cf curl /v3/users and cf curl /v3/spaces/:guid/users to confirm that only a subset of users was returned. User missing from the space level call was the network-policy

$ cf curl /v3/spaces/369cc547-b6b8-4ccb-a3c3-987845b04049/users | grep total_results
    "total_results": 3,

$ cf curl /v3/users | grep total_results
    "total_results": 4,

• confirmed that permissions for each role are correct, results are identical for all roles except OrgAuditor, which receives a 404. This matches the error code received by OrgAuditors when curling /v3/spaces/:guid.

Docs Check

Looks good, ran docs locally and they render as expected

[sweinstein22]

Running through acceptance again as the implementation changed pretty significantly.

Behavior Check

As a space supporter, confirmed that the list of users returned for a space is a subset of those returned from /v3/users:

$ cf curl /v3/spaces/369cc547-b6b8-4ccb-a3c3-987845b04049/users | grep total_results
    "total_results": 6,
$ cf curl /v3/users | grep total_results
    "total_results": 8,

Also confirmed that output of endpoint looked correct, and then checked to make sure there wasn't a diff in output between roles.

$ diff space-supporter space-manager

$ diff space-supporter space-dev

$ diff space-supporter space-auditor

$ diff space-supporter org-manager

Confirmed that org auditors get a 404:

$ cf curl /v3/spaces/369cc547-b6b8-4ccb-a3c3-987845b04049/users -v
REQUEST: [2021-09-08T09:58:20-07:00]
GET /v3/spaces/369cc547-b6b8-4ccb-a3c3-987845b04049/users HTTP/1.1
...

RESPONSE: [2021-09-08T09:58:20-07:00]
HTTP/1.1 404 Not Found
...
{
  "errors": [
    {
      "code": 10010,
      "detail": "Space not found",
      "title": "CF-ResourceNotFound"
    }
  ]
}

Code Check

Looks good! Thanks for rearranging things so we would have more consistent patterns, and for introducing a new model to minimize how much data processing we're doing

Docs Check

New endpoint is documented, renders as expected