-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide pageable org users endpoint #2495
Conversation
be1c3ec
to
1a48578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running through preliminary acceptance even though this is still a draft as I'm going to be out of office today.
Behavior Check
Confirmed that result of running /v3/organizations/:guid/users
returned fewer results than /v3/users
and that output looked correct:
$ cf curl /v3/organizations/c2daec28-4340-4e9c-bf94-a026419b2b8c/users | grep total_results
"total_results": 8,
$ cf curl /v3/users | grep total_results
"total_results": 10,
Compared admin result to result as each role:
$ diff admin org-auditor
$ diff admin org-manager
$ diff admin space-auditor
$ diff admin space-manager
$ diff admin space-supporter
$ diff admin space-dev
Code Check
Pending further discussion with the team to talk about unifying our approach, but these changes look reasonable to me if this is the approach we decide on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs Check
Confirmed that docs render correctly, looks like we've got a couple typos in the work "organization" (currently spelled "organzation") - this should be adjusted in the sidebar, the title, and the definition of the section for this new endpoint
I believe we also chatted about changing up the wording to be 'List users for an organization', to prevent confusion given that an org user is an assignable role. If we do make this adjustment it would be great to align the space level endpoint with the new wording
1a48578
to
0191f75
Compare
Resolved; ready for a new review
Acceptance`
] Checked this after assigning a second user to this org, LGTM, merging! |
Explained in #2489. Adds
/v3/organizations/:guid/users
.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests