Improve service keys quota check performance #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change the existing service keys count is fetched only when the quota for total_service_keys is not -1 (i.e. unlimited). This removes an unneeded database query.
- Don't fetch them upfront if not needed - Issue less db queries Co-authored-by: Katharina Przybill <katharina.przybill@sap.com>
While improving the selection of existing service keys and reducing the
number of database queries from 3 ([1]) to 1 ([2]), we found out that
the sub-select queries were very slow (for a large number of service
instances) due to a missing index.
[1]
SELECT * FROM "spaces" WHERE ("organization_id" = <ORG_ID>);
SELECT * FROM "service_instances" WHERE ("space_id" IN (<SPACE_IDS>));
SELECT count(*) AS "count" FROM "service_keys"
WHERE ("service_instance_id" IN (<SERVICE_INSTANCE_IDS>)) LIMIT 1;
[2]
SELECT count(*) AS "count" FROM "service_keys"
WHERE ("service_instance_id" IN (
SELECT "id" FROM "service_instances" WHERE ("space_id" IN (
SELECT "id" FROM "spaces" WHERE ("organization_id" = <ORG_ID>)
))
)) LIMIT 1;
Co-authored-by: Katharina Przybill <katharina.przybill@sap.com>
This was referenced Nov 8, 2021
andy-paine
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance of the service keys quota check is improved by the following means:
service_instance_idtoservice_keystable.When running the new tests added to cf-performance-tests locally, the response time decreases from ~2,9 to 0,05 seconds with the changes in this PR.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests