Use Concurrent::Semaphore for broker rate limiter #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concurrent-ruby package has some classes that essentially do the same thing as we were trying to do so we can use those rather than relying on our own code Also add the DELETE method into the rate limiter and add a log line for when users exceed this limit for monitoring whether the limit is correctly set Signed-off-by: Andy Paine <andrew.paine@sap.com>
philippthun
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change
Switch to using concurrent-ruby's semaphore for the service broker rate limiter
An explanation of the use cases your change solves
The concurrent-ruby package has some classes that essentially do the
same thing as we were trying to do so we can use those rather than
relying on our own code
Also add the DELETE method into the rate limiter and add a log line for
when users exceed this limit for monitoring whether the limit is
correctly set
Links to any other associated PRs
Improvement on #2563
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests