Use permissions subqueries in service list fetchers #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add readable_orgs_query and readable_space_scoped_spaces_query to Permissions and use them as input to ServiceOfferingListFetcher.fetch and ServicePlanListFetcher.fetch.
sethboyles
approved these changes
Dec 10, 2021
johha
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 14, 2022
As a regular user the select query for service credential bindings is filtered by a list of space guids (spaces the user has access to). This can produce very long queries. Instead we can use subqueries to filter the spaces directly in the db. Same approach is used in service lists, see cloudfoundry#2580.
5 tasks
johha
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 14, 2022
As a regular user the select query for service credential bindings is filtered by a list of space guids (spaces the user has access to). This can produce very long queries. Instead we can use subqueries to filter the spaces directly on the db. The same approach is used in the list services endpoint, see cloudfoundry#2580.
johha
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 15, 2022
As a regular user the select query for service credential bindings is filtered by a list of space guids (spaces the user has access to). This can produce very long queries. Instead we can use subqueries to filter the spaces directly on the db. The same approach is used in the list services endpoint, see cloudfoundry#2580.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
readable_orgs_queryandreadable_space_scoped_spaces_querytoPermissionsand use them as input toServiceOfferingListFetcher.fetchandServicePlanListFetcher.fetch.When running the cf-performance-tests locally, improvements for the following endpoints could be observed:
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests