Fix pollable job cleanup logger name #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also rename local variables from "blob" to "job" (looks like a copy&paste mistake from expired_orphaned_blob_cleanup.rb)
philippthun
reviewed
Dec 7, 2021
philippthun
approved these changes
Dec 7, 2021
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
* Rename logger to match class name * Also rename local variables from "blob" to "job"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Fixes logger name ("cc.background.expired-orphaned-blob-cleanup" is used by another background job). Also fixes local variable names (looks like a copy&paste error from expired_orphaned_blob_cleanup.rb)
An explanation of the use cases your change solves
Links to any other associated PRs
We found this when investigating Blobstore error messages when pushing CF Docker apps #2582
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests