Fix blobstore errors for droplets from CF Docker apps #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes cloudfoundry#2582 Signed-off-by: Jochen Ehret <jochen.ehret@sap.com>
* but still make sure that Docker droplets are marked as "EXPIRED" in the db Signed-off-by: Aftab Alam <a.alam@sap.com>
philippthun
requested changes
Dec 10, 2021
philippthun
requested changes
Dec 10, 2021
* highlight the difference between buildpack and Docker droplet handling Signed-off-by: Philipp Thun <philipp.thun@sap.com>
philippthun
approved these changes
Dec 10, 2021
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Dec 16, 2022
) * Don't trigger droplet deletion job for Docker apps but still make sure that Docker droplets are marked as "EXPIRED" in the db * Refactor expired_blob_cleanup test to highlight the difference between buildpack and Docker droplet handling * Fixes cloudfoundry#2582 Co-authored-by: Aftab Alam <81828613+iaftab-alam@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
PR fixes droplet deletion error messages for Docker apps. For details, see Blobstore error messages when pushing CF Docker apps #2582
An explanation of the use cases your change solves
See Blobstore error messages when pushing CF Docker apps #2582
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests