New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove copilot #3355
Merged
Merged
Remove copilot #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Please close this Issue once this is merged: |
cats broke on [FAIL] [services] Service Instance Lifecycle Synchronous operations [BeforeEach] when there is an app bindings can bind service to app and check app env and events
/home/pivotal/workspace/cf-acceptance-tests/helpers/services/broker.go:114 app log failures 2023-08-25T19:27:27.34+0000 [API/0] OUT Added process: "web"
2023-08-25T19:27:27.35+0000 [API/0] OUT Created app with guid c7a89aaf-777b-4117-9054-04294bed8c52
2023-08-25T19:27:27.38+0000 [API/0] OUT Applied manifest to app with guid c7a89aaf-777b-4117-9054-04294bed8c52 (---
2023-08-25T19:27:27.38+0000 [API/0] OUT applications:
2023-08-25T19:27:27.38+0000 [API/0] OUT - name: CATS-4-BRKR-03bc69d76a2f20df
2023-08-25T19:27:27.38+0000 [API/0] OUT health-check-type: http
2023-08-25T19:27:27.38+0000 [API/0] OUT health-check-http-endpoint: "/v2/catalog"
2023-08-25T19:27:27.39+0000 [API/0] OUT path: "/home/pivotal/workspace/cf-acceptance-tests/assets/service_broker"
2023-08-25T19:27:27.39+0000 [API/0] OUT memory: 256M
2023-08-25T19:27:27.39+0000 [API/0] OUT default-route: true
2023-08-25T19:27:27.39+0000 [API/0] OUT buildpacks:
2023-08-25T19:27:27.39+0000 [API/0] OUT - ruby_buildpack
2023-08-25T19:27:27.39+0000 [API/0] OUT )
2023-08-25T19:27:30.43+0000 [API/0] OUT Updating process: "web"
2023-08-25T19:27:30.45+0000 [API/0] OUT Scaling process: "web"
2023-08-25T19:27:30.48+0000 [API/0] OUT Updated app with guid c7a89aaf-777b-4117-9054-04294bed8c52 ({"lifecycle"=>{"data"=>{"buildpacks"=>["ruby_buildpack"]}}})
2023-08-25T19:27:30.55+0000 [API/0] OUT Updated app with guid c7a89aaf-777b-4117-9054-04294bed8c52 ({"environment_variables"=>"[PRIVATE DATA HIDDEN]"})
2023-08-25T19:27:34.02+0000 [API/0] OUT Uploading app package for app with guid c7a89aaf-777b-4117-9054-04294bed8c52
2023-08-25T19:27:37.26+0000 [API/0] OUT Creating build for app with guid c7a89aaf-777b-4117-9054-04294bed8c52
2023-08-25T19:27:37.41+0000 [STG/0] OUT Downloading ruby_buildpack...
2023-08-25T19:27:37.41+0000 [STG/0] OUT Downloaded ruby_buildpack
2023-08-25T19:27:37.41+0000 [STG/0] OUT Cell 3676e6ab-f490-48be-9bcc-a8f21724fe95 creating container for instance 07bb839b-d50b-4ca9-b94f-506bf94c9482
2023-08-25T19:27:37.83+0000 [STG/0] OUT Security group rules were updated
2023-08-25T19:27:37.85+0000 [STG/0] OUT Cell 3676e6ab-f490-48be-9bcc-a8f21724fe95 successfully created container for instance 07bb839b-d50b-4ca9-b94f-506bf94c9482
2023-08-25T19:27:38.35+0000 [STG/0] OUT Downloading app package...
2023-08-25T19:27:38.38+0000 [STG/0] OUT Downloaded app package (933.2K)
2023-08-25T19:27:38.49+0000 [STG/0] OUT -----> Ruby Buildpack version 1.10.3
2023-08-25T19:27:38.49+0000 [STG/0] OUT -----> Bootstrapping Ruby
2023-08-25T19:27:38.49+0000 [STG/0] OUT -----> Installing ruby 3.1.4
2023-08-25T19:27:38.49+0000 [STG/0] OUT Download [https://buildpacks.cloudfoundry.org/dependencies/ruby/ruby_3.1.4_linux_x64_cflinuxfs4_700bcbf9.tgz]
2023-08-25T19:27:39.58+0000 [STG/0] OUT **ERROR** Error during bootstrap: unexpected EOF
2023-08-25T19:27:39.59+0000 [STG/0] ERR Failed to compile droplet: Failed to run all supply scripts: exit status 15
2023-08-25T19:27:39.59+0000 [STG/0] OUT Exit status 223
2023-08-25T19:27:40.06+0000 [STG/0] OUT Cell 3676e6ab-f490-48be-9bcc-a8f21724fe95 stopping instance 07bb839b-d50b-4ca9-b94f-506bf94c9482
2023-08-25T19:27:40.06+0000 [STG/0] OUT Cell 3676e6ab-f490-48be-9bcc-a8f21724fe95 destroying container for instance 07bb839b-d50b-4ca9-b94f-506bf94c9482
2023-08-25T19:27:40.11+0000 [API/0] ERR Failed to stage build: staging failed
2023-08-25T19:27:40.99+0000 [STG/0] OUT Cell 3676e6ab-f490-48be-9bcc-a8f21724fe95 successfully destroyed container for instance 07bb839b-d50b-4ca9-b94f-506bf94c9482 will take time that I don't have now to figure out what thing I deleted that I shouldn't have help from others always appreciated if this pr speaks to you |
moleske
force-pushed
the
removecopilot
branch
from
October 20, 2023 22:41
bb21fe7
to
e41130e
Compare
- copilot is archived and not used no more
moleske
force-pushed
the
removecopilot
branch
from
October 30, 2023 23:48
e41130e
to
79f7122
Compare
Acceptance tests passing on a bosh lite with the following config {
"api": "api.wouldntyouliketoknow.example.com",
"apps_domain": "wouldntyouliketoknow.example.com",
"admin_user": "admin",
"admin_password": "definitelythepassword",
"skip_ssl_validation": true,
"use_http": true,
"include_apps": true,
"include_capi_experimental": true,
"include_detect": true,
"include_security_groups": true,
"include_services": true,
"include_v3": true,
"include_tasks": true,
"include_backend_compatibility": false,
"include_capi_no_bridge": false,
"include_container_networking": false,
"include_credhub" : false,
"include_docker": false,
"include_internet_dependent": false,
"include_isolation_segments": false,
"include_persistent_app": false,
"include_private_docker_registry": false,
"include_privileged_container_support": false,
"include_route_services": false,
"include_routing": false,
"include_routing_isolation_segments": false,
"include_service_discovery": false,
"include_service_instance_sharing": false,
"include_ssh": false,
"include_sso": false,
"include_zipkin": false
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
copilot is archived and not used no more. so we should remove it
An explanation of the use cases your change solves
oleske likes less code
Links to any other associated PRs
Remove copilot capi-release#329 - must be merged with it
need to run cf acceptance tests to make sure nothing strange going on. then undraft
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests