Enable CF API to present routable field for app processes
#3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows whether or not the app's readiness check is passing on an app instance, and whether or not if routes will be sent to it. Signed-off-by: Brandon Roberson <broberson@vmware.com> Co-authored-by: Brandon Roberson <broberson@vmware.com>
|
As is, this PR may cause confusion for clients if this code is used in conjunction with a diego release that doesn't support readiness checks. If diego doesn't provide |
|
Ok, pushed up a commit that's more compatible with environments where CAPI supports readiness but diego doesn't. |
…pport readiness checks Signed-off-by: Geoff Franks <gfranks@vmware.com> Signed-off-by: Brandon Roberson <broberson@vmware.com> Signed-off-by: Geoff Franks <gfranks@vmware.com>
geofffranks
force-pushed
the
app-readiness-status
branch
from
5ff77b9
to
054e06a
Compare
philippthun
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables CF API clients to provide feedback to developers on whether apps are currently passing readiness checks and are routable.
https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0020-readiness-healthchecks.md#cli-changes