Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ForeignKeyConstraintViolation during migration #3811

Merged
merged 1 commit into from
May 24, 2024

Conversation

philippthun
Copy link
Member

  • Reproduced reported issue by enhancing the unit test.
  • Fixed ForeignKeyConstraintViolation by re-ordering migration statements.

Fixes issue #3803.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

- Reproduced reported issue by enhancing the unit test.
- Fixed ForeignKeyConstraintViolation by re-ordering migration
  statements.

Fixes issue cloudfoundry#3803.
Copy link
Member

@Benjamintf1 Benjamintf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethboyles
Copy link
Member

Looks good, thanks for the fix!

@sethboyles sethboyles merged commit 01473c7 into cloudfoundry:main May 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"add_delete_cascade_to_foreign_keys.rb" Can fail due to missing Builds
3 participants