Pass encryption headers on copy. #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey jmcarp! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/127705337 The labels on this github issue will be updated when the story is started. |
jmcarp
changed the title
ghost
mentioned this pull request
|
Hi @jmcarp, Looks good, thanks for the pull request! @adowns01 && @thausler786 |
cf-gitbot
added
delivered
scheduled
in progress
and removed
unscheduled
delivered
scheduled
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
FogClient.cp_file_between_keysto both copy and save files with the specified encryption options. This handles the edge case where encryption is mandatory for an S3 bucket--to ensure that all of our files are encrypted, we configure our buckets to reject any PUTs without encryption set. With this patch, S3 objects are encrypted at all times, instead of copying an object unencrypted and then re-encrypting it afterwards.