Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More restrictions updating Isolation Segments #712

Merged
merged 2 commits into from
Nov 9, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 3, 2016

  1. Admins should not be able to unassign an org from an IS if the org has that IS set as its default.

The case where there are any apps in a space without an IS set blocks the removal of this IS, but it does not block operators from accidentally removing the default IS and unintentionally deploying their apps to the shared isolation segment.

  1. Cannot update an Isolation Segment name if:
    A. The Isolation Segment is assigned to an Organization's default and there is a space w/o out an Isolation Segment containing apps.
    B. The Isolation Segment is assigned to any Space containing apps.

[finishes #131555045 #133867895]

Signed-off-by: Sandy Cash scarlet.tanager@gmail.com

than 1 isolations segments for an organization

[finishes #131555045]

Signed-off-by: Sandy Cash <scarlet.tanager@gmail.com>
@cfdreddbot
Copy link

Hey DanLavine!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/133693043

The labels on this github issue will be updated when the story is started.

- when is an org default, spaces w/o a specified IS contain apps
- when assigned to a specific space containing apps

[finishes #133867895]

Signed-off-by: Dan Lavine <dlavine@us.ibm.com>
@ghost ghost changed the title Do not allow removal of default isolation segment if there are more More restrictions updating Isolation Segments Nov 7, 2016
@aashah aashah merged commit c992710 into cloudfoundry:master Nov 9, 2016
@ScarletTanager ScarletTanager deleted the isolation_segments branch January 23, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants