Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC: Candidate Eligibility: Non-code contributions #59

Closed
bkrannich opened this issue Jan 28, 2021 · 10 comments
Closed

TOC: Candidate Eligibility: Non-code contributions #59

bkrannich opened this issue Jan 28, 2021 · 10 comments
Labels

Comments

@bkrannich
Copy link
Contributor

https://github.com/cloudfoundry/community/blob/main/TOC.md#candidate-eligibility
Similar to #58, TOC members, WG Leads, and Approvers seems to favour code contributions over non-code contributions. I'd like to ask the question if this is the intention when it comes to TOC candidates?

@bkrannich bkrannich changed the title Candidate Eligibility: Non-code contributions TOC: Candidate Eligibility: Non-code contributions Jan 28, 2021
@loewenstein
Copy link

This came up already when we were talking about the bootstrapping of the TOC, as there are currently no eligible candidates at all.

@chipchilders
Copy link
Contributor

Ability to ask for an exception for TOC eligibility criteria should be added to both TOC and MIGRATION

@bkrannich
Copy link
Contributor Author

@chipchilders: When you write "ask for an exception" it sound like "usually" we do favour code contributions over other contributions for TOC candidates. Not sure if this is the intent, thus I opened this Github issue.

@chipchilders
Copy link
Contributor

@loewenstein says that @bkrannich is happy now and that we can close it

@bkrannich
Copy link
Contributor Author

@chipchilders, @loewenstein: Confirming my happiness 😄 - thanks!

@loewenstein loewenstein reopened this Apr 12, 2021
@bkrannich
Copy link
Contributor Author

Hi @chipchilders,

Looking at the latest version in the repo together with @loewenstein, I am not sure my initial intent for opening this issue is still represented in the current wording when it comes to non-code contributions.

I understood from @loewenstein that https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#scope-of-technical-contributions is a disclaimer that is trying to include non-contributions for the remainder of the document but I am not sure people reading the document would intuitively understand this intent.

Let's make a couple of examples:

I think the above examples are less clear than the ability to merge code into an official repo. However, I believe the intention is for the above examples to allow these types of contributions to fall under the Approver role. This is why I liked your suggestion in #59 (comment) to define an exception process but I learned from @loewenstein that the exception process has been removed meanwhile.

I guess my ask would either be to make it more clear in the wording of the documents how the above examples would be viewed or to reconsider an exception process for them.

Thanks in advance.

@chipchilders
Copy link
Contributor

The community should discuss during the Friday meeting. If you can make it, that would be helpful!

@chipchilders
Copy link
Contributor

@bkrannich hopefully the discussion last week helped clarify the working group's prior deliberations that led to the current approach. I believe, based on that conversation, that you were OK with (1) that voter eligibility was clear enough and (2) that TOC eligibility should absolutely require demonstrated support for the project in an official technical community leadership role. The only question was about the role definitions, to be sure that they clearly indicated the types of technical community work that qualified "non-code" contributors for leadership roles. You took the action to review with that context in mind. Can you let the governance working group know if you are OK, or if you have any suggested changes, via either this issue or a PR into the appropriate files?

@bkrannich
Copy link
Contributor Author

@chipchilders Yes, I am fine with your summary. In terms of the actual text, Valentina is about to prepare some suggestions to make the wording more clear (without changing what you wrote in your previous comment, I'd say) and will send that to you as input by EOB today.

@chipchilders
Copy link
Contributor

Reviewed and approved by GB. We can continue to iterate on the ROLES.md as the new TOC leads the community through the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants