Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the ali repositories into a sub area #800

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

mvach
Copy link
Contributor

@mvach mvach commented Mar 28, 2024

No description provided.

@beyhan
Copy link
Member

beyhan commented Mar 28, 2024

@xiaozhu36 could you please review this and put a dumps up if it is fine for you.

@@ -326,6 +323,9 @@ areas:
github: xiaozhu36
repositories:
- cloudfoundry/bosh-alicloud-cpi-release
- cloudfoundry/bosh-alicloud-light-stemcell-builder
- cloudfoundry/bosh-ali-storage-cli

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the maintainer of the repo cloudfoundry/bosh-ali-storage-cli, and I can not review and approve its prs. Other repos are ok.

Copy link

@xiaozhu36 xiaozhu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add the approver for the repo cloudfoundry/bosh-ali-storage-cli

@xiaozhu36
Copy link

HI @beyhan Can I have maintainer permission so that I can merge PR and publish new releases?

@beyhan
Copy link
Member

beyhan commented Apr 2, 2024

@xiaozhu36 I think we could merge this as it is and add Matthias and maybe others who want to maintain the bosh-ali-storage-cli repo as approvers to this area so that we keep everything in one area. Is it OK for you?

@xiaozhu36
Copy link

@beyhan Sounds better. I am ok.

@beyhan beyhan requested a review from xiaozhu36 April 3, 2024 11:42
@jpalermo jpalermo merged commit 4a530c8 into cloudfoundry:main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants