Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

187452409 postgres fk idx #748

Merged
merged 3 commits into from
Jun 7, 2024
Merged

187452409 postgres fk idx #748

merged 3 commits into from
Jun 7, 2024

Conversation

hsinn0
Copy link
Contributor

@hsinn0 hsinn0 commented Jun 7, 2024

Tried creating the index with 1 million records, but did not notice significant performance issues for creating the index during Flyway migration. It was done in 1 seconds in my dev env. This does not necessarily mean that there won't be no slowdown during the index creation in the field, as my local environment is simple and there was no active database transaction while the index was created. As the implementation is supposed to create index without lock, we will just have to release it and hope that it works smoothly for most deployments our there.

- On `credential_version.credential_uuid`.
- As not having the index have negative impact on query performance.

[#187452409]
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Copy link
Contributor

@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this looks good. Not clear on the issue this links back to

@hsinn0 hsinn0 merged commit b0001dc into main Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants