test: factor duplicated code into test helper

acceptance-tests/helpers/apps/testappmanifests.go

@@ -1,9 +1,7 @@
 package apps
 
 import (
-	"fmt"
-	"os"
-	"path/filepath"
+	"csbbrokerpakgcp/acceptance-tests/helpers/testpath"
 )
 
 type ManifestCode string
@@ -14,18 +12,7 @@ const (
 )
 
 func (a ManifestCode) Path() string {
-	for _, d := range []string{"apps", "../apps"} {
-		p, err := filepath.Abs(filepath.Join(d, string(a)))
-		if err != nil {
-			panic(fmt.Sprintf("error resolving absolute path: %s", err))
-		}
-
-		if _, err := os.Stat(p); err == nil {
-			return p
-		}
-	}
-
-	panic(fmt.Sprintf("could not find source for app manifest: %s", a))
+	return testpath.BrokerpakFile("acceptance-tests", "apps", string(a))
 }
 
 func WithTestAppManifest(manifest ManifestCode) Option {

acceptance-tests/helpers/apps/testapps.go

@@ -1,9 +1,7 @@
 package apps
 
 import (
-	"fmt"
-	"os"
-	"path/filepath"
+	"csbbrokerpakgcp/acceptance-tests/helpers/testpath"
 )
 
 type AppCode string
@@ -20,15 +18,7 @@ const (
 )
 
 func (a AppCode) Dir() string {
-	for _, d := range []string{"apps", "../apps"} {
-		p := filepath.Join(d, string(a))
-		_, err := os.Stat(p)
-		if err == nil {
-			return p
-		}
-	}
-
-	panic(fmt.Sprintf("could not find source for app: %s", a))
+	return testpath.BrokerpakFile("acceptance-tests", "apps", string(a))
 }
 
 func WithApp(app AppCode) Option {

acceptance-tests/helpers/brokers/create.go

@@ -1,8 +1,8 @@
 package brokers
 
 import (
+	"csbbrokerpakgcp/acceptance-tests/helpers/testpath"
 	"fmt"
-	"os"
 	"strings"
 
 	"csbbrokerpakgcp/acceptance-tests/helpers/apps"
@@ -94,23 +94,11 @@ func WithPassword(password string) Option {
 func defaultConfig(opts ...Option) (broker Broker) {
 	defaults := []Option{
 		WithName(random.Name(random.WithPrefix("broker"))),
-		WithSourceDir(defaultSourceDir()),
+		WithSourceDir(testpath.BrokerpakRoot()),
 		WithUsername(random.Name()),
 		WithPassword(random.Password()),
 		WithEncryptionSecret(random.Password()),
 	}
 	WithOptions(append(defaults, opts...)...)(&broker)
 	return broker
 }
-
-func defaultSourceDir() string {
-	for _, d := range []string{"..", "../.."} {
-		p := fmt.Sprintf("%s/%s", d, "cf-manifest.yml")
-		_, err := os.Stat(p)
-		if err == nil {
-			return d
-		}
-	}
-
-	panic("could not find source for broker app")
-}

acceptance-tests/helpers/testpath/brokerpak_file.go

@@ -0,0 +1,22 @@
+package testpath
+
+import (
+	"fmt"
+	"path"
+	"path/filepath"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+func BrokerpakFile(parts ...string) string {
+	GinkgoHelper()
+
+	r := BrokerpakRoot()
+	p := filepath.Join(append([]string{r}, parts...)...)
+	Expect(p).To(BeAnExistingFile(), func() string {
+		return fmt.Sprintf("could not find file %q in brokerpak %q", path.Join(parts...), r)
+	})
+
+	return p
+}

acceptance-tests/helpers/testpath/brokerpak_root.go

@@ -0,0 +1,36 @@
+package testpath
+
+import (
+	"fmt"
+	"os"
+	"path/filepath"
+
+	"github.com/onsi/ginkgo/v2"
+)
+
+// BrokerpakRoot searches upwards from the current working directory to find the root path of the brokerpak
+// Fails the test if not found
+func BrokerpakRoot() string {
+	ginkgo.GinkgoHelper()
+
+	cwd, err := os.Getwd()
+	if err != nil {
+		panic(err)
+	}
+
+	d, err := filepath.Abs(cwd)
+	if err != nil {
+		panic(err)
+	}
+
+	for {
+		switch {
+		case Exists(filepath.Join(d, "manifest.yml")) && Exists(filepath.Join(d, "acceptance-tests")):
+			return d
+		case d == "/":
+			ginkgo.Fail(fmt.Sprintf("could not determine brokerpak root from %q", cwd))
+		default:
+			d = filepath.Dir(d)
+		}
+	}
+}

acceptance-tests/helpers/testpath/exists.go

@@ -0,0 +1,26 @@
+// Package testpath provides path utilities for tests
+package testpath
+
+import (
+	"os"
+	"strings"
+
+	"github.com/onsi/ginkgo/v2"
+)
+
+// Exists returns whether a path exists, failing the test on error
+func Exists(path string) bool {
+	ginkgo.GinkgoHelper()
+
+	_, err := os.Stat(path)
+	switch {
+	case err == nil:
+		return true
+	case strings.Contains(err.Error(), "NotFound"):
+		return false
+	default:
+		ginkgo.Fail(err.Error())
+	}
+
+	return false // unreachable
+}