chore: avoid pushing the broker in acceptance tests unnecessarily #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we started GAing services our approach was to test GAed services with the ENABLE_BETA_SERVICE_OFFERINGS flag to false. In this way we could also test that the GAed service would be always available. We haven't replicated this kind of approach for other services so this now is not consistent with the rest of the tests. It would be better to just have a dedicated test for the catalog to double check this behavior than to slow down our tests and consume extra resources by pushing yet another broker [#186011659](https://www.pivotaltracker.com/story/show/186011659)
zucchinidev
approved these changes
Sep 14, 2023
|
Thank you very much @pivotal-marcela-campo ! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we started GAing services our approach was to test GAed services with the ENABLE_BETA_SERVICE_OFFERINGS flag to false. In this way we could also test that the GAed service would be always available. We haven't replicated this kind of approach for other services so this now is not consistent with the rest of the tests. It would be better to just have a dedicated test for the catalog to double check this behavior than to slow down our tests and consume extra resources by pushing yet another broker
#186011659
Checklist: