Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diego-logging-client #714

Merged
merged 1 commit into from Mar 6, 2023
Merged

Update diego-logging-client #714

merged 1 commit into from Mar 6, 2023

Conversation

winkingturtle-vmw
Copy link
Contributor

@winkingturtle-vmw winkingturtle-vmw commented Mar 1, 2023

to SendSpikeMetrics with EmitTimer instead of EmitGauge

This is to mitigate an issue that started to happen when we started using syslog-ingress. This will help cpu-entitlement-plugin to correctly consume from LogCache.

Context:
cloudfoundry/cf-deployment#949

Thank you for submitting a pull request to the diego-release repository. We appreciate the contribution. To help us with getting better context for the pull request please follow these guidelines:

Please make sure to complete the following steps

  • Before PR Submission, Submit an issue for either an Enhancement or Bug
  • Check the Contributing document on how to sign the CLA and run tests in diego-release.
  • Make sure a pull request is done against the develop branch.

Issue Link

Please link the issue you created above for a bug or enhancement.

Thank you!

to SendSpikeMetrics with EmitTimer instead of EmitGauge

This is to mitigate an issue that started to happen when we started using
syslog-ingress

Context:
[cloudfoundry/cf-deployment#949](cloudfoundry/cf-deployment#949)
Copy link
Contributor

@ebroberson ebroberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariash mariash merged commit 3e87320 into develop Mar 6, 2023
@jrussett jrussett deleted the with-emit-timer branch January 19, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants