Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove systemcerts from sync-submodule-config #809

Merged

Conversation

jrussett
Copy link
Contributor

@jrussett jrussett commented Aug 25, 2023

This is a follow up to: #808

We don't need to sync code.cloudfoundry.org/systemcerts anymore because we removed it.

Fixes:

+ ./scripts/sync-submodule-config
+ export PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin
+ PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin
+ mkdir -p bin
+ cd src/gosub
+ go build -o ../../bin/gosub .
+ FORCE_SUBMODULE_HTTPS=true
+ rm -rf /tmp/packages
+ cat
+ cat /tmp/packages
+ xargs -s 1048576 gosub sync --force-https=true
failed to get dependency repo: chdir /tmp/build/a22dd28d/diego-release/src/code.cloudfoundry.org/systemcerts: no such file or directory

#184870112

This is a follow up to: #808

We don't need to sync code.cloudfoundry.org/systemcerts anymore because
we removed it.

Fixes:
```
+ ./scripts/sync-submodule-config
+ export PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin
+ PATH=/tmp/build/a22dd28d/diego-release/bin:/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/tmp/build/a22dd28d/diego-release/bin
+ mkdir -p bin
+ cd src/gosub
+ go build -o ../../bin/gosub .
+ FORCE_SUBMODULE_HTTPS=true
+ rm -rf /tmp/packages
+ cat
+ cat /tmp/packages
+ xargs -s 1048576 gosub sync --force-https=true
failed to get dependency repo: chdir /tmp/build/a22dd28d/diego-release/src/code.cloudfoundry.org/systemcerts: no such file or directory
```

[#184870112](https://www.pivotaltracker.com/story/show/184870112)
@jrussett jrussett requested a review from a team as a code owner August 25, 2023 21:48
@ameowlia ameowlia merged commit 26f3f26 into develop Aug 25, 2023
1 check passed
@jrussett jrussett deleted the fix-sync-submodule-config-after-removing-systemcerts branch August 25, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants