Update envoy's http2 configs to not use deprecated options anymore #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofffranks
force-pushed
the
envoy-http2-deprecation-fix
branch
from
a02cace
to
673f6e0
Compare
winkingturtle-vmw
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Out of curiosity: Why remove and not use the v3 options? https://github.com/envoyproxy/envoy/blob/dc21640dff119e1365aa8286b7c34a1f0585e147/api/envoy/config/core/v3/protocol.proto#L427
There was a problem hiding this comment.
I attempted this, but wasn't able to validate whether or not i was generating the correct envoy yaml, since the feature wouldn't work for me even prior to changing anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This http2 config was only used when the experimental
containers.proxy.ads_serversattribute was present, which does not appear to work anymore anyway as specifying it causes containers to crash on envoy startup due to other unsupported configuration.