default grace time to indefinite #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a default grace time of 5 minutes means there's no way to create a container with an indefinite TTL. It also doesn't seem like a sane default; either everyone has to disable it manually or the consumer of Garden has to continuously heartbeat containers that it wants to keep. The CLI defaults to indefinite, so this also makes them consistent with each other.
|
Hey vito! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
Hi there! We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created. The current status is as follows:
This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes. |
barthy1
pushed a commit
to barthy1/garden-runc-release
that referenced
this pull request
Mar 9, 2017
[finishes #135205219] Submodule src/github.com/tchap/go-patricia 42daf53..666120d: > Improve remove() in the sparse mode > Fix remove() in the sparse children mode > Merge pull request cloudfoundry#25 from aristanetworks/master > Fix Delete memory leak and other bugs found > Merge pull request cloudfoundry#23 from dmitris/issue20 > Merge pull request cloudfoundry#22 from dmitris/showmemory > Fix a panic when deleting Signed-off-by: Georgi Sabev <georgethebeatle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning included in commit message.
Note: with this change, Diego can probably stop configuring this in their manifest. This change is also needed for Concourse's new container/volume lifecycle where we no longer heartbeat with GraceTime and instead have an explicit GC.
Alternatively we could remove this property? That would mean
0means indefinite. Or we could keep it and make theGraceTimefield a pointer, wherenilwould mean "server default" and0would mean "indefinite". (Or some other approach to add the distinction.)