Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change: log a little more information when backend endpoints fail
An explanation of the use cases your change solves: we are experiencing a small number of backend failures during platform updates. We would like a little more information in the logs, as provided by this PR
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics): can trigger this log by stopping a traffic-receiving VM with
bosh stop --skip-drain diego-cell/N
Expected result after the change: extra context in the logs, like can be seen here and in the PR:
{"log_level":3,"timestamp":"2021-07-13T15:01:30.452379948Z","message":"backend-endpoint-failed","source":"vcap.gorouter","data":{"retriable":true,"num-endpoints":1, [...]}}
Current result before the change: the
retriable
andnum-endpoints
fields aren't present, which makes it a little harder to follow what behaviour Gorouter will do nextI have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
scripts/run-unit-tests-in-docker
from routing-release.I have deployed this in a CF environment and checked the new log fields print as expected
(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
(Optional) I have run CF Acceptance Tests on bosh lite