Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2 traffic to backends is configurable #290

Merged
merged 2 commits into from
Aug 11, 2021
Merged

HTTP/2 traffic to backends is configurable #290

merged 2 commits into from
Aug 11, 2021

Conversation

Gerg
Copy link
Member

@Gerg Gerg commented Jul 22, 2021 •
edited

  • A short explanation of the proposed change:

Follow up to #289 that makes the configuration introduced in #285 also apply to Gorouter's communication with its backends.

  • An explanation of the use cases your change solves

Operators that want to fully disable HTTP/2 communication on their deployments can prevent Gorouter from issuing HTTP/2 requests to applications.

  • Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)

Set https://bosh.io/jobs/gorouter?source=github.com/cloudfoundry/routing-release&version=0.218.0#p%3drouter.enable_http2 to false and follow steps from #289. The app should receive HTTP/1.1 traffic, even when the endpoint is configured with the http2 protocol.

  • Links to any other associated PRs

#289 & #285

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using scripts/run-unit-tests-in-docker from routing-release.

  • (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite

  • (Optional) I have run CF Acceptance Tests on bosh lite

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@Gerg Gerg mentioned this pull request Aug 9, 2021
Merged
5 tasks
@Gerg
Copy link
Member Author

Gerg commented Aug 9, 2021

Can be marked "Ready for review" once #289 is merged.

@moleske moleske marked this pull request as ready for review August 11, 2021 20:05
Gerg and others added 2 commits August 11, 2021 20:13
@Gerg @ameowlia
Disable HTTP/2 to backends when HTTP/2 is disabled
2e66577 
- The "EnableHTTP2" configuration previously controlled whether Gorouter
would serve HTTP/2.
- Now, the same configuration also affects Gorouter's communication with
its app backends

[cloudfoundry/routing-release#200]
@Gerg @ctlong @ameowlia
Update README with end-to-end HTTP/2 info
9c0d059 
[#178138110]
[cloudfoundry/routing-release#200]

Co-authored-by: Carson Long <lcarson@vmware.com>
@ameowlia ameowlia merged commit 8ed808e into main Aug 11, 2021
@ameowlia ameowlia deleted the configurable_http2_backends branch August 11, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unscheduled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerg @cf-gitbot @ameowlia