Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance registry logs with appId, instanceId and domainSans #291

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

thomas-kaltenbach
Copy link
Contributor

@thomas-kaltenbach thomas-kaltenbach commented Jul 29, 2021

  • A short explanation of the proposed change:
    Log out the appId, instanceId and domainSans at (un)registrations for debugging and correlation of different log entries. Similar to Enhance accesslogs with InstanceId for better debugging #293

  • An explanation of the use cases your change solves
    We face currently some issues (x509: certificate is valid for <instance_guid>, not <instance_guid>) during landscape update. We would like to correlate exactly the endpoint registration logs with some logs from the runtime logs (i.e. BBS,REP,CC). This change enable us to search for the instanceId or applicationId and find the starting/stopping/crashing container, accesslogs (with PR Enhance accesslogs with InstanceId for better debugging #293) and also the endpoint-(un)registration logs of the gorouter.
    This would help us a lot.

  • Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
    Deploy the change and have a look at the logs.

  • Expected result after the change
    The log entries "endpoint-registered" and "endpoint-unregistered" should have know the fields application_id, instance_id and server_cert_domain_san.
    {"log_level":1,"timestamp":1627540143.12727,"message":"endpoint-registered","source":"test","data":{"uri":"b.route","backend":":0","application_id":"app_id1","instance_id":"instance_id1","server_cert_domain_san":"san1","modification_tag":{"guid":"","index":0},"isolation_segment":"-","isTLS":false}}

  • Current result before the change
    {"log_level":1,"timestamp":1627540143.12727,"message":"endpoint-registered","source":"test","data":{"uri":"b.route","backend":":0","modification_tag":{"guid":"","index":0},"isolation_segment":"-","isTLS":false}}

  • links to any other associated PRs
    Enhance accesslogs with InstanceId for better debugging #293

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using scripts/run-unit-tests-in-docker from routing-release.

  • I have build an routing release and deployed it on our devlandscape

  • (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite

  • (Optional) I have run CF Acceptance Tests on bosh lite

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@ameowlia ameowlia merged commit 1f40d95 into cloudfoundry:main Aug 17, 2021
@ameowlia
Copy link
Member

Thank you @thomas-kaltenbach for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants