[Chore]: Get rid of integration tests for the /v3/builds endpoints

[gcapizzi]

Background

In order to simplify our testing strategy, we want to get rid of envtest-based integration tests for our handlers.

Action to take

• Make sure that all paths tested by api/apis/integration/build_test.go are covered by our unit tests in api/apis/build_handler_test.go.
• Remove api/apis/integration/build_test.go.

Impact

• Make our unit tests comprehensive
• Reduce overlap in our tests and thus cost of maintenance

[benjaminguttmann-avtq]

@gcapizzi I would be interested in supporting here but have struggle how to takle it. Do we maybe have an example of similar task I can have a look into ?

[gcapizzi]

@benjaminguttmann-avtq hello, sorry for the late reply!

The idea of these tasks is to remove a set of redundant tests. We believe our handlers should only be tested with unit tests (which use mocks for dependencies) and don't need to also be tested in integration (with real dependencies) using envtest. Before doing that though, we want to make sure that we don't lose any coverage by doing this.

So we want to:

• check that our unit tests cover everything the integration tests do;
• backfill the missing unit tests if needed;
• remove the integration tests.

I can't find a PR doing something similar but every PR will look different, as every set of handler might have a different level of coverage in the two test suites.