Consistent Logging Severity #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Output URL, method, contentLength, remoteAddr for requests - Output statusCode, size, duration for responses - Correlation IDs included with both Co-authored-by: Kieron Browne <kbrowne@vmware.com>
Logs will be info level if error is or wraps an apierrors error, otherwise at error level Co-authored-by: Kieron Browne <kbrowne@vmware.com>
and use in unauthenticated endpoints. This allows consistent logging with the correlation-id enhanced logger, for example. Co-authored-by: Kieron Browne <kbrowne@vmware.com>
This error type is intended for wrapping unknown errors by the handler wrapping / presenting framework. In these cases, a plain error is the correct type to return. Co-authored-by: Kieron Browne <kbrowne@vmware.com>
It is not correct to return plain errors here as they translate to 503 http response statuses Co-authored-by: Kieron Browne <kbrowne@vmware.com>
This showed up as an error with the improved logging, but wasn't causing any user noticable problem Co-authored-by: Kieron Browne <kbrowne@vmware.com>
Co-authored-by: Kieron Browne <kbrowne@vmware.com>
kieron-dev
force-pushed
the
issues/1340-consitent-log-severity
branch
from
adfeedf
to
b74e94c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1340
What is this change about?
Does this PR introduce a breaking change?
No
Acceptance Steps
No logs at the error level after running e2e suite
Tag your pair, your PM, and/or team
@kieron-dev
Things to remember