Rename helm packageRegistrySecret to containerRegistrySecret #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The global value is used as package, droplet and kpack-build repository secrets, so it makes sense to call it containerRegistrySecret. Issue: #1923
danail-branekov
approved these changes
Nov 25, 2022
danail-branekov
deleted the
issues/1923-global-registry-secret-rename
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1923
What is this change about?
The global value is used as package, droplet and kpack-build repository
secrets, so it makes sense to call it containerRegistrySecret.
Does this PR introduce a breaking change?
Yes - helm chart value is renamed
Acceptance Steps
Install korifi helm chart using the new name for the global registry secret and check you can push an app.
Tag your pair, your PM, and/or team
Things to remember