Trigger a kpack build if requested buildpack changes #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieron-dev
approved these changes
May 10, 2023
Kpack would not trigger a build if the builder in the kpack image changes and latest build had failed (e.g. push with buildpack A that fails and then try to push with buildpack B) - see buildpacks-community/kpack#1198 In order to work around this kpack limitation we annotate the latest build with `image.kpack.io/additionalBuildNeeded` annotation that forces kpack into creating a new build thus picking up the builder specified in the kpack image. Co-authored-by: Kieron Browne <kbrowne@vmware.com>
kieron-dev
force-pushed
the
issues/2474-recover-from-skipped-builds
branch
from
9cfcebb
to
1f4367f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2474
What is this change about?
Kpack would not trigger a build if the builder in the kpack image changes and latest build had failed (e.g. push with buildpack A that fails and then try to push with buildpack B) - see buildpacks-community/kpack#1198
In order to work around this kpack limitation we annotate the latest build with
image.kpack.io/additionalBuildNeededannotation that forces kpack into creating a new build thus picking up the builder specified in the kpack image.Does this PR introduce a breaking change?
No
Acceptance Steps
cf push dorifi -p ~/workspace/korifi/tests/e2e/assets/golang -b paketo-buildpacks/java-> See it failingcf push dorifi -p ~/workspace/korifi/tests/e2e/assets/golang -b paketo-buildpacks/go-> see it starts a new build and eventually succeedTag your pair, your PM, and/or team
@kieron-dev