Remove EphemeralContainers feature gate from Kind config #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ephemeral Containers have been promoted to GA as of Kubernetes 1.27 and this feature gate has been removed See: kubernetes/kubernetes#111402 - Having it set prevents Kind clusters from starting successfully with versions >= 1.27 Authored-by: Tim Downey <tdowney@vmware.com>
davewalter
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Does this PR introduce a breaking change?
Korifi devs usingActually they likely will. It has defaulted todeploy-on-kind.shto deploy to older Kind cluster versions may no longer have ephemeral debug containers enabled.truesince K8s 1.23. (Search for "EphemeralContainers" here: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/)This does not impact users running Korifi.
Acceptance Steps
Run
deploy-on-kind.shand have it create a Kind cluster with K8s >= 1.27.Tag your pair, your PM, and/or team
@davewalter