Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually propagate kpack service-account #261

Merged
merged 3 commits into from Nov 19, 2021
Merged

Manually propagate kpack service-account #261

merged 3 commits into from Nov 19, 2021

Conversation

acosta11
Copy link
Member

@acosta11 acosta11 commented Nov 18, 2021

Is there a related GitHub Issue?

#243

What is this change about?

Update HNC config script to propagate secrets and not service accounts

Does this PR introduce a breaking change?

No

Acceptance Steps

Install cf dependencies with the install-dependencies.sh script
Install cf on a cluster with auth disabled using the make deploy target
Configure ingress as necessary
Login to the cf api
Follow instructions in the README.md for Space Creation to create a space with image build configured
Apply sample resources as necessary to trigger a build

Tag your pair, your PM, and/or team

pair w/ @davewalter

@acosta11 acosta11 force-pushed the staging-apps branch 3 times, most recently from adeede1 to f953eca Compare November 18, 2021 00:27
README.md Outdated Show resolved Hide resolved
acosta11 and others added 2 commits November 18, 2021 16:33
Move kind image load into SKIP_DOCKER_BUILD conditional block

Co-authored-by: Dave Walter <walterda@vmware.com>
- use correct root namespace for e2e tests

Co-authored-by: Andrew Costa <ancosta@vmware.com>
Co-authored-by: Tim Downey <tdowney@vmware.com>
Copy link
Member

@tcdowney tcdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- we see a lot of test failures in CI due to excessive parallelization
- number of nodes can be adjusted by setting `TEST_NUM_NODES`
@davewalter davewalter merged commit 72f1cce into main Nov 19, 2021
@davewalter davewalter deleted the staging-apps branch November 19, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants