Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix otel-collector-windows packaging script #366

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

acrmp
Copy link
Member

@acrmp acrmp commented Aug 17, 2023

Description

  • PR Build otel-collector distribution #360 changed the otel-collector-windows packaging script to use Windows-style backslashes as path delimiters
  • This isn't actually desirable everywhere because the first line of the packaging script exists to prevent an error when exporting a BOSH release and attempting to compile this Windows package on a Linux instance

Fixes:

.exiter.ps1: No such file or directory

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

- PR #360 changed the otel-collector-windows packaging script to use
  Windows-style backslashes as path delimiters
- This isn't actually desirable because this line exists to prevent an
  error when exporting a BOSH release and attempting to compile this
  Windows package on a Linux instance

Fixes:
  .exiter.ps1: No such file or directory
@acrmp acrmp requested a review from a team as a code owner August 17, 2023 02:50
DEPRECATED App Platform - Logging and Metrics automation moved this from Reviewer Assigned to Review in Progress Aug 17, 2023
@acrmp acrmp merged commit 355e595 into main Aug 17, 2023
7 checks passed
DEPRECATED App Platform - Logging and Metrics automation moved this from Review in Progress to Done Aug 17, 2023
@acrmp acrmp deleted the fix-otel-windows-export-release branch August 17, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants