Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register loggregator agent when not enabled #456

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

acrmp
Copy link
Member

@acrmp acrmp commented Jan 9, 2024

Description

Don't register loggregator agent with forwarder agent or prom scraper when the loggregator agent is not enabled.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Manual testing

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

Don't register loggregator agent with forwarder agent or prom scraper
when the loggregator agent is not enabled.
@acrmp acrmp requested a review from a team as a code owner January 9, 2024 00:31
@acrmp acrmp merged commit 12b08e5 into main Jan 9, 2024
7 checks passed
@acrmp acrmp deleted the dont-register-when-disabled branch January 9, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants