Skip to content
This repository has been archived by the owner on Oct 12, 2021. It is now read-only.

Commit

Permalink
Remove varz shim from metron
Browse files Browse the repository at this point in the history
[#92719926]

Signed-off-by: John Tuley <jtuley@pivotal.io>
  • Loading branch information
Kira Combs authored and John Tuley committed Jun 22, 2015
1 parent 8aa9626 commit dee5e0f
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 426 deletions.
26 changes: 0 additions & 26 deletions src/integration_tests/metron/varz_healthz_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,32 +60,6 @@ var _ = Describe("/varz endpoint", func() {
return getMetricFromContext(agentListenerContext, "receivedMessageCount").Value
}).Should(BeNumerically(">=", expectedValue))
})

It("includes value metrics from sources", func() {
connection, _ := net.Dial("udp", "localhost:51161")
connection.Write(basicValueMessage())

Eventually(func() *instrumentation.Context { return getContext("forwarder") }).ShouldNot(BeNil())

metric := getMetricFromContext(getContext("forwarder"), "fake-origin-2.fake-metric-name")
Expect(metric).ToNot(BeNil())
Expect(metric.Name).To(Equal("fake-origin-2.fake-metric-name"))
Expect(metric.Value).To(BeNumerically("==", 42))
Expect(metric.Tags["component"]).To(Equal("test-component"))
})

It("includes counter event metrics from sources", func() {
connection, _ := net.Dial("udp", "localhost:51161")
connection.Write(basicCounterEventMessage())
connection.Write(basicCounterEventMessage())

Eventually(func() *instrumentation.Context { return getContext("forwarder") }).ShouldNot(BeNil())

metric := getMetricFromContext(getContext("forwarder"), "fake-origin-2.fake-counter-event-name")
Expect(metric.Name).To(Equal("fake-origin-2.fake-counter-event-name"))
Expect(metric.Value).To(BeNumerically("==", 2))
Expect(metric.Tags["component"]).To(Equal("test-component"))
})
})

var _ = Describe("/healthz", func() {
Expand Down
7 changes: 1 addition & 6 deletions src/metron/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"metron/writers/messageaggregator"
"metron/writers/signer"
"metron/writers/tagger"
"metron/writers/varzforwarder"

"github.com/cloudfoundry/gosteno"
"github.com/cloudfoundry/gunk/workpool"
Expand All @@ -34,8 +33,6 @@ var (
debug = flag.Bool("debug", false, "Debug logging")
)

var metricTTL = time.Second * 5

func main() {
flag.Parse()
config, logger := parseConfig(*debug, *configFilePath, *logFilePath)
Expand All @@ -45,8 +42,7 @@ func main() {
dopplerForwarder := dopplerforwarder.New(dopplerClientPool, logger)
byteSigner := signer.New(config.SharedSecret, dopplerForwarder)
marshaller := eventmarshaller.New(byteSigner, logger)
varzShim := varzforwarder.New(config.Job, metricTTL, marshaller, logger)
messageTagger := tagger.New(config.Deployment, config.Job, config.Index, varzShim)
messageTagger := tagger.New(config.Deployment, config.Job, config.Index, marshaller)
aggregator := messageaggregator.New(messageTagger, logger)

dropsondeUnmarshaller := eventunmarshaller.New(aggregator, logger)
Expand All @@ -62,7 +58,6 @@ func main() {
legacyUnmarshaller,
dropsondeUnmarshaller,
aggregator,
varzShim,
marshaller,
}

Expand Down
55 changes: 0 additions & 55 deletions src/metron/writers/varzforwarder/metrics.go

This file was deleted.

100 changes: 0 additions & 100 deletions src/metron/writers/varzforwarder/varz_forwarder.go

This file was deleted.

13 changes: 0 additions & 13 deletions src/metron/writers/varzforwarder/varz_forwarder_suite_test.go

This file was deleted.

0 comments on commit dee5e0f

Please sign in to comment.