This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Use pivotal-golang for localip [#82988760] #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kris Hicks <krishicks@gmail.com>
|
Hey Amit-PivotalLabs! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
Hey @Amit-PivotalLabs and @krishicks, We'd really like to accept this PR, but the tests fail consistently on Travis. (Pay no attention to the allowed failure on go-tip.) Can you take care of that, and then we'll merge this in? Thanks! |
|
@Amit-PivotalLabs Never mind; it looks like something changed in a version of testify that came out four hours after the last pass of loggregatorlib. We'll look into the failure. |
jmtuley
added a commit
that referenced
this pull request
Dec 4, 2014
Use pivotal-golang for localip [#82988760]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kris Hicks krishicks@gmail.com