-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nfsbroker can push to cf/249, diego/1.0.0, nfs-volume/1.0.6 #22
Comments
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/150461780 The labels on this github issue will be updated when the story is started. |
Can you run |
My guess is that this line in
Probably the posgres release you are using serializes port as a string not a number. As an experiment, you could try changing it to:
And let us know if that fixes the issue. If so, then we probably need to add some type assertions to accept port as a string or a number. |
out put of "cf env nfsbroker" (domain name were masked) System-Provided: { User-Provided: |
After changed line 183 of main.go to ./main.go:183: cannot use credentials["port"] (type interface {}) as type string in assignment: need type assertion |
change line 183 of main.go to *dbPort = credentials["port"].(string) worked. |
Very good, thanks for the feedback. We'll try to get a fix in for this case shortly. |
Closing this as fixed. Please re-open if you still see the issue. |
Submodule src/code.cloudfoundry.org/nfsbroker a695a02..277a09a: > 🤖 go mod vendor > Merge pull request #22 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/existingvolumebroker-0.11.0 > 🤖 go mod vendor > Merge pull request #24 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/service-broker-store-0.4.0 > 🤖 go mod vendor > Merge pull request #23 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/goshims-0.3.0
Submodule src/code.cloudfoundry.org/nfsv3driver b49bdd8..f7d4542: > go mod vendor > Merge pull request #22 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.5.0
Submodule src/code.cloudfoundry.org/nfsv3driver bc0fe75..8b6921d: > Implemented a cache option > go mod vendor > Merge pull request #22 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.5.0 > 🤖 go mod vendor > Merge pull request #21 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/goshims-0.3.0 > 🤖 go mod vendor > Merge pull request #20 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.4.0 > go mod vendor > Update go dependencies > Remove github actions > Merge pull request #19 from cloudfoundry/go-mod-tidy-20200311213050 > Merge pull request #17 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.3.0 > Merge pull request #18 from cloudfoundry/go-mod-tidy-20200311212549 > Merge pull request #16 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volume-mount-options-0.3.0 > Merge pull request #15 from cloudfoundry/go-mod-tidy-20200310211248 > Add github token to have ability to create a PR > Manually bump nfsv3driver onto goshims 0.1.0 > Manually bump nfsv3driver to volume-mount-options v0.1.0 > Manually bump nfsv3driver onto volumedriver v0.1.0 > Merge pull request #12 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.0 > Merge pull request #11 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.9.0 > Hardcode uniqueVolumeIds to true > Add Makefile for running specs > Fix docker driver integration tests to no longer allow default-in-mount, allowed-in-mount options > Remove allowed-in-mount and default-in-mount configurations > remove useless/misleading "intr" option from list of nfs mount options > go module bump > Code refactor > Bump volumedriver > Run go mod vendor and go mod tidy > Bump volume driver and use new Invoke API > use the latest volume-mount-options > update vendored modules > Merge pull request #10 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.8.1 > Merge pull request #8 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.8.0 > Merge pull request #9 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.11.0 > Bump volumedriver > Refactor > Refactor > Bump volumedriver > correct script for running docker driver integration tests > Bump volumedriver > Refactor - Use new pgInvoker > remove unnecessary GO111MODULE setting [#169684821](https://www.pivotaltracker.com/story/show/169684821) > minor code clean up in integration test script [#169684821](https://www.pivotaltracker.com/story/show/169684821) > remove vestigial cruft from the README > build mapfs directly, instead of in mapfs-release when integration testing [#169684821](https://www.pivotaltracker.com/story/show/169684821) > add integration tests that run directly from this repo [#169684821](https://www.pivotaltracker.com/story/show/169684821) > add scripts to run units directly from this repo [#169684821](https://www.pivotaltracker.com/story/show/169684821) > Remove unused mount option 'fsname' > Bump volume mount options > Use vendored modules for suite test > Merge pull request #6 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.10.3 > Merge pull request #7 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.7.1
Submodule src/code.cloudfoundry.org/nfsv3driver 1fed479...ef3cf74: > Ignore minimum TLS warning < go mod vendor < Merge pull request #46 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.14.0 < go mod vendor < Merge pull request #45 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.15.0 < go mod vendor < Merge pull request #44 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.5 < go mod vendor < Merge pull request #43 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.12.0 < Revert "Add harbor cache for docker rate limiting" < Revert "Add harbor cache for docker rate limiting" < go mod vendor < Merge pull request #42 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.11.0 < Add harbor cache for docker rate limiting < Add harbor cache for docker rate limiting < go mod vendor < Merge pull request #41 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.4 < go mod vendor < Merge pull request #40 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.3 < go mod vendor < Merge pull request #39 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.14.2 < go mod vendor < Merge pull request #38 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.2 < go mod vendor < Merge pull request #37 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.14.1 < go mod vendor < Merge pull request #36 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.14.0 < go mod vendor < Merge pull request #35 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.13.0 < go mod vendor < Merge pull request #34 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.3 < go mod vendor < Merge pull request #33 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.10.0 < go mod vendor < Merge pull request #32 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.2 < go mod vendor < Merge pull request #30 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.9.0 < go mod vendor < Merge pull request #29 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.1 < go mod vendor < Merge pull request #25 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.7.0 < go mod vendor < Merge pull request #26 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/goshims-0.4.0 < go mod vendor < Merge pull request #24 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.0 > compatibility changes to work with newer volume-mount-options [#172568984](https://www.pivotaltracker.com/story/show/172568984) > Implemented a cache option < Implemented a cache option < go mod vendor < Merge pull request #22 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.5.0 < 🤖 go mod vendor < Merge pull request #21 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/goshims-0.3.0 < 🤖 go mod vendor < Merge pull request #20 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.4.0 < go mod vendor < Update go dependencies < Remove github actions < Merge pull request #19 from cloudfoundry/go-mod-tidy-20200311213050 < Merge pull request #17 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.3.0 < Merge pull request #18 from cloudfoundry/go-mod-tidy-20200311212549 < Merge pull request #16 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volume-mount-options-0.3.0 < Merge pull request #15 from cloudfoundry/go-mod-tidy-20200310211248 < Add github token to have ability to create a PR < Manually bump nfsv3driver onto goshims 0.1.0 < Manually bump nfsv3driver to volume-mount-options v0.1.0 < Manually bump nfsv3driver onto volumedriver v0.1.0 < Merge pull request #12 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.0 < Merge pull request #11 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.9.0 < Hardcode uniqueVolumeIds to true < Add Makefile for running specs < Fix docker driver integration tests to no longer allow default-in-mount, allowed-in-mount options < Remove allowed-in-mount and default-in-mount configurations < remove useless/misleading "intr" option from list of nfs mount options < go module bump < Code refactor < Bump volumedriver < Run go mod vendor and go mod tidy < Bump volume driver and use new Invoke API < use the latest volume-mount-options < update vendored modules < Merge pull request #10 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.8.1 < Merge pull request #8 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.8.0 < Merge pull request #9 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.11.0 < Bump volumedriver < Refactor < Refactor < Bump volumedriver < correct script for running docker driver integration tests < Bump volumedriver < Refactor - Use new pgInvoker < remove unnecessary GO111MODULE setting [#169684821](https://www.pivotaltracker.com/story/show/169684821) < minor code clean up in integration test script [#169684821](https://www.pivotaltracker.com/story/show/169684821) < remove vestigial cruft from the README < build mapfs directly, instead of in mapfs-release when integration testing [#169684821](https://www.pivotaltracker.com/story/show/169684821) < add integration tests that run directly from this repo [#169684821](https://www.pivotaltracker.com/story/show/169684821) < add scripts to run units directly from this repo [#169684821](https://www.pivotaltracker.com/story/show/169684821) < Remove unused mount option 'fsname' < Bump volume mount options < Use vendored modules for suite test < Merge pull request #6 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.10.3 < Merge pull request #7 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.7.1 < Migrate to use go modules
Submodule src/code.cloudfoundry.org/nfsv3driver ef3cf74...1bf3c87: < Ignore minimum TLS warning > Ignore minimum TLS warning > go mod vendor > Merge pull request #46 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.14.0 > go mod vendor > Merge pull request #45 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.15.0 > go mod vendor > Merge pull request #44 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.5 > go mod vendor > Merge pull request #43 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.12.0 > Revert "Add harbor cache for docker rate limiting" > Revert "Add harbor cache for docker rate limiting" > go mod vendor > Merge pull request #42 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.11.0 > Add harbor cache for docker rate limiting > Add harbor cache for docker rate limiting > go mod vendor > Merge pull request #41 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.4 > go mod vendor > Merge pull request #40 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.3 > go mod vendor > Merge pull request #39 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.14.2 > go mod vendor > Merge pull request #38 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.2 > go mod vendor > Merge pull request #37 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.14.1 > go mod vendor > Merge pull request #36 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.14.0 > go mod vendor > Merge pull request #35 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.13.0 > go mod vendor > Merge pull request #34 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.3 > go mod vendor > Merge pull request #33 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.10.0 > go mod vendor > Merge pull request #32 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.2 > go mod vendor > Merge pull request #30 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.9.0 > go mod vendor > Merge pull request #29 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.1 > go mod vendor > Merge pull request #25 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.7.0 > go mod vendor > Merge pull request #26 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/goshims-0.4.0 > go mod vendor > Merge pull request #24 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.10.0 < compatibility changes to work with newer volume-mount-options [#172568984](https://www.pivotaltracker.com/story/show/172568984) < Implemented a cache option > Implemented a cache option > go mod vendor > Merge pull request #22 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.5.0 > 🤖 go mod vendor > Merge pull request #21 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/goshims-0.3.0 > 🤖 go mod vendor > Merge pull request #20 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.4.0 > go mod vendor > Update go dependencies > Remove github actions > Merge pull request #19 from cloudfoundry/go-mod-tidy-20200311213050 > Merge pull request #17 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volumedriver-0.3.0 > Merge pull request #18 from cloudfoundry/go-mod-tidy-20200311212549 > Merge pull request #16 from cloudfoundry/dependabot/go_modules/code.cloudfoundry.org/volume-mount-options-0.3.0 > Merge pull request #15 from cloudfoundry/go-mod-tidy-20200310211248 > Add github token to have ability to create a PR > Manually bump nfsv3driver onto goshims 0.1.0 > Manually bump nfsv3driver to volume-mount-options v0.1.0 > Manually bump nfsv3driver onto volumedriver v0.1.0 > Merge pull request #12 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.12.0 > Merge pull request #11 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.9.0 > Hardcode uniqueVolumeIds to true > Add Makefile for running specs > Fix docker driver integration tests to no longer allow default-in-mount, allowed-in-mount options > Remove allowed-in-mount and default-in-mount configurations > remove useless/misleading "intr" option from list of nfs mount options > go module bump > Code refactor > Bump volumedriver > Run go mod vendor and go mod tidy > Bump volume driver and use new Invoke API > use the latest volume-mount-options > update vendored modules > Merge pull request #10 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.8.1 > Merge pull request #8 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.8.0 > Merge pull request #9 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.11.0 > Bump volumedriver > Refactor > Refactor > Bump volumedriver > correct script for running docker driver integration tests > Bump volumedriver > Refactor - Use new pgInvoker > remove unnecessary GO111MODULE setting [#169684821](https://www.pivotaltracker.com/story/show/169684821) > minor code clean up in integration test script [#169684821](https://www.pivotaltracker.com/story/show/169684821) > remove vestigial cruft from the README > build mapfs directly, instead of in mapfs-release when integration testing [#169684821](https://www.pivotaltracker.com/story/show/169684821) > add integration tests that run directly from this repo [#169684821](https://www.pivotaltracker.com/story/show/169684821) > add scripts to run units directly from this repo [#169684821](https://www.pivotaltracker.com/story/show/169684821) > Remove unused mount option 'fsname' > Bump volume mount options > Use vendored modules for suite test > Merge pull request #6 from cloudfoundry/dependabot/go_modules/github.com/onsi/ginkgo-1.10.3 > Merge pull request #7 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.7.1 > Migrate to use go modules
I am trying to push nfsbroker as cf app.
The app builds fine, and pushed to cf without problem. However, it failed to start with/without cf bind to postgresql service instantances.
cf logs nfsbroker --recent showing following error:
2017-08-22T14:37:54.64-0700 [APP/PROC/WEB/0] OUT Exit status 2
2017-08-22T14:37:54.66-0700 [CELL/0] OUT Exit status 0
2017-08-22T14:37:54.67-0700 [CELL/0] OUT Destroying container
2017-08-22T14:37:54.69-0700 [CELL/0] OUT Creating container
2017-08-22T14:37:54.95-0700 [CELL/0] OUT Successfully destroyed container
2017-08-22T14:37:54.99-0700 [CELL/0] OUT Successfully created container
2017-08-22T14:37:55.21-0700 [CELL/0] OUT Starting health monitoring of container
2017-08-22T14:37:55.30-0700 [APP/PROC/WEB/0] OUT {"data":{},"log_level":1,"message":"nfsbroker.starting","source":"nfsbroker","timestamp":"1503437875.308967352"}
2017-08-22T14:37:55.30-0700 [APP/PROC/WEB/0] OUT {"data":{},"log_level":1,"message":"nfsbroker.ends","source":"nfsbroker","timestamp":"1503437875.309250116"}
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR panic: interface conversion: interface {} is string, not float64
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR goroutine 1 [running]:
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR main.parseVcapServices(0xa7d980, 0xc42001e420)
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR /home/user01/manifest/nfs-volume-release/src/code.cloudfoundry.org/nfsbroker/main.go:183 +0x65d
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR main.createServer(0xa7d980, 0xc42001e420, 0xc42001e420, 0x89491b)
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR /home/user01/manifest/nfs-volume-release/src/code.cloudfoundry.org/nfsbroker/main.go:192 +0x77e
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR main.main()
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] ERR /home/user01/manifest/nfs-volume-release/src/code.cloudfoundry.org/nfsbroker/main.go:118 +0x1bc
2017-08-22T14:37:55.31-0700 [APP/PROC/WEB/0] OUT Exit status 2
2017-08-22T14:37:55.32-0700 [CELL/0] OUT Exit status 0
2017-08-22T14:37:55.33-0700 [CELL/0] OUT Destroying container
2017-08-22T14:37:55.61-0700 [CELL/0] OUT Successfully destroyed container
snipet of manifest.yml
buildpack: binary_buildpack
env:
SERVICENAME: nfs #service name to publish in the marketplace
USERNAME: admin
PASSWORD: goodpassword
LOGLEVEL: info #error, warn, info, debug
DBDRIVERNAME: postgres #mysql or postgres
DBHOST: 10.8.8.8
DBPORT: 9999
DBNAME: something
DB_USERNAME: something
DB_PASSWORD: something
DBCACERT: something
Thank you for your help!
The text was updated successfully, but these errors were encountered: