Install any new modules after "rebuilding" existing dependencies

[svennam92]

Seems we are missing some important logic to install any new modules when rebuilding existing dependencies

You used to have it:

nodejs-buildpack/lib/build.sh

Line 174 in cc9339a

info "Installing any new modules"

but not any longer:
f43aa96#diff-cbea48db73996bd0b8adcff9b6b7fbd2L186

We should install any new dependencies after doing the "rebuild". This allows some dependencies to be pushed with the application in "node_modules", and others to be downloaded as specified in package.json

My scenario that caused this issue:
Push fresh application (no cache) with undeclared dependencies in node_modules. This is considered prebuilt, so it rebuilds the dependencies I've included in node_modules. However, I had express in my package.json (but not in node_modules), and it never got installed.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/94525966.

[flavorjones]

Should be addressed when we merge upstream in https://www.pivotaltracker.com/story/show/93482010

We'll leave this open until we merge and verify we've addressed it.

[flavorjones]

This is fixed in nodejs-buildpack v1.3.3:

• https://github.com/cloudfoundry/nodejs-buildpack/releases/tag/v1.3.3

We've also submitted a PR to runtime to have this version bundled with `cf-release:

• Upgrading nodejs buildpack to v1.3.3 cloudfoundry-attic/cf-release#685

Thanks again for reporting this!