Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align npm dependencies logic with legacy behavior #21

Closed
wants to merge 2 commits into from
Closed

Align npm dependencies logic with legacy behavior #21

wants to merge 2 commits into from

Conversation

svennam92
Copy link
Contributor

Spawned from issue #20 and #22

  1. Turn caching off if node_modules is pushed with application
  2. Install new modules if node_modules is pushed with the application, not only rebuild the existing ones.

@cfdreddbot
Copy link

Hey svennam92!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/94525540.

@flavorjones
Copy link
Contributor

Hi @svennam92,

As discussed in #20, we're going to pull upstream changes from Heroku to address #20 and #22. To that end, I'm going to close this PR.

Thanks so much for letting us know we're out of date, and for putting in the effort to describe and fix this behavior. I really appreciate it!

Cheers,
-mike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants