Feat: toggle HTTP/2 functionality #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
mkocher
force-pushed
the
feat/enable_http2
branch
from
5e53332
to
5a8103d
Compare
ameowlia
reviewed
May 27, 2021
3 tasks
* `enable_http2`, defaults to false * Set to true to enable communicating with apps via HTTP/2 [cloudfoundry#200] Co-authored-by: Merric de Launey <mdelauney@vmware.com> Co-authored-by: Carson Long <lcarson@vmware.com> Co-authored-by: Weyman Fung <weymanf@vmware.com>
Co-authored-by: Matthew Kocher <mkocher@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've added a bosh property to the routing-release called
router.enable_http2that configures HTTP/2 support for Gorouter as part of #200.router.enable_http2defaults to false.Should be merged after cloudfoundry/gorouter#278.
Instructions to try it out
Deploy routing release with
router.enable_http2not set, curl Gorouter with HTTP/2, see your request fail with a protocol error.Deploy routing release with
router.enable_http2set to true, curl Gorouter with HTTP/2, see your request succeed.Deploy routing release with
router.enable_http2set to false, curl Gorouter with HTTP/2, see your request fail with a protocol error.I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run all the unit tests using
scripts/run-unit-tests-in-docker(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
(Optional) I have run CF Acceptance Tests on bosh lite
TODO: