Fix up removing reliance on bosh link named NATS #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property used to be used to set the hostname to connect to NATS over mTLS. We now get that from the nats-tls link and this property is already no longer used.
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
5 tasks
|
If we can get this shipped in a new version soon that'd be a big help internally for SAP. ❤️ |
|
Ready for review. |
|
@46bit Thanks for making these changes! It looks like the template specs are failing with these changes, can you take a look? Thanks, Andrew. |
We use both 'host' and 'hostname' in different places to store the same data. This led to some mistakes in the testsuite. This commit fixes the last mistaken use of 'host' in the NATS bosh link.
|
@acrmp Confused how I missed that! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: this provides some changes minor requested in a comment by @acrmp
A short explanation of the proposed change: this removes the deprecated
nats.tls.hostnameproperty, and fixes a misnamed field in a testI have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run all the unit tests using
scripts/run-unit-tests-in-docker(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
(Optional) I have run CF Acceptance Tests on bosh lite