Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tabs with spaces (and fix indent) of YAML in code blocks #67

Merged

Conversation

nota-ja
Copy link
Contributor

@nota-ja nota-ja commented Mar 2, 2017

In order to be viewed properly on GitHub.

In order to be viewed properly on GitHub.
@cfdreddbot
Copy link

Hey nota-ja!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/140920763

The labels on this github issue will be updated when the story is started.

@shashwathi shashwathi merged commit a44b5db into cloudfoundry:develop Mar 2, 2017
@shashwathi
Copy link
Contributor

@nota-ja

Thank you for submitting the PR.

Regards
Shash

@shalako
Copy link
Contributor

shalako commented Mar 2, 2017

Although the sentiment that spaces are preferred over tabs is acknowledged, this commit actually broke the formatting for most of the YML blocks it changed.

@nota-ja
Copy link
Contributor Author

nota-ja commented Mar 6, 2017

Thank you for merging.

But I have one question.

@shalako, what do you mean with "broke the formatting"?

The images in the right column in the following table are the rendered view of the README.md of my commit ( 966729c ).

The images in the left column are the one of the previous commit ( a4287e8 , the HEAD commit of develop branch when this pull request was made) as well.

All of them were captured with Chrome 56.0.2924.87 (64-bit) on Mac.

commit a4287e8 (older) 966729c (this)
image
partially enlarged

The last row contains enlarged images for each commit. I will use them for the following explanation.

As you see in this example deployment manifest, the right structure of the part of the YAML is:

  • properties
    • uaa
      • ssl
        • port
      • sslCertificate
      • sslPrivateKey

However, the rendered view of the old commit is seen as:

  • properties
    • uaa
  • ssl
    • port
  • sslCertificate
  • sslPrivateKey

As I thought this was wrong, I made this pull request.
Actually the rendered view of my commit is seen as:

  • properties
    • uaa
      • ssl
        • port
      • sslCertificate
      • sslPrivateKey

So I think my commit did not "break" the formatting.

@shalako
Copy link
Contributor

shalako commented Mar 6, 2017

I must have been looking at the wrong branch. Develop looks good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants