Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Move this repo into a release #52

Closed
winkingturtle-vmw opened this issue May 10, 2023 · 2 comments
Closed

Move this repo into a release #52

winkingturtle-vmw opened this issue May 10, 2023 · 2 comments

Comments

@winkingturtle-vmw
Copy link

Why

Silk was created so that it could be used outside of CF, go-import paths show that after the many years in production, CF silk-release is the only user of this plugin.

As a user
I want merge silk code into silk-release (or preferred cf-networking-release see cloudfoundry/silk-release#83)
So that we can simplify our pipeline and process without having to bump silk outside of the release and waiting long enough to bump within the silk-release. This will additionally remove concourse jobs that redundant (e.g bump-silk-in-silk-release)

What

code.cloudfoundry.org/silk will be archived and will contain README redirecting anyone that will arrive at the repo to the preferred release instead.

Acceptance Criteria

code.cloudfoundry.org/silk will no longer be used in our jobs.

@ameowlia
Copy link
Member

ameowlia commented Jul 6, 2023

I love this idea.

reneighbor added a commit that referenced this issue Aug 2, 2023
This repo is being merged into silk-release. See the following:
- #52
- cloudfoundry/silk-release#89

[#185149418](https://www.pivotaltracker.com/story/show/185149418)

Signed-off-by: Josh Russett <jrussett@vmware.com>
jrussett added a commit to cloudfoundry/silk-release that referenced this issue Aug 3, 2023
We had originally setup silk in an enitre other repo with the intention
that it could be imported, used, and extended by other projects.
This never happened and now we have a separate repo for `silk` when it
is only used in `silk-release.

This commit takes [code.cloudfoundry.org/silk at commit
8e48b8d1e6812ccd3da7c93fb30728ad1d9000ed](cloudfoundry/silk@8e48b8d),
and folds it into `silk-release` under `src/code.cloudfoundry.org/silk`.

Other changes worth mentioning:
- `scripts/test.sh` and `scripts/start-db-helper` taken from
  `cf-networking`, e.g. https://github.com/cloudfoundry/cf-networking-release/blob/develop/scripts/test.sh
    - the `silk` tests now require some databases to run
- removes scripts from the `silk` source repo
- Updates bosh packaging specs for the new pakage import path
- Consolidates `modules/modules.go` and `tools/tools.go` since they seem
  to do the same thing and we don't need to import the silk stuff

Addresses: cloudfoundry/silk#52

[#185149418](https://www.pivotaltracker.com/story/show/185149418)

Signed-off-by: Renee Chu <reneec@vmware.com>
winkingturtle-vmw pushed a commit that referenced this issue Aug 3, 2023
This repo is being merged into silk-release. See the following:
- #52
- cloudfoundry/silk-release#89

[#185149418](https://www.pivotaltracker.com/story/show/185149418)

Signed-off-by: Josh Russett <jrussett@vmware.com>
Co-authored-by: Renee Chu <reneec@vmware.com>
winkingturtle-vmw pushed a commit to cloudfoundry/silk-release that referenced this issue Aug 3, 2023
We had originally setup silk in an enitre other repo with the intention
that it could be imported, used, and extended by other projects.
This never happened and now we have a separate repo for `silk` when it
is only used in `silk-release.

This commit takes [code.cloudfoundry.org/silk at commit
8e48b8d1e6812ccd3da7c93fb30728ad1d9000ed](cloudfoundry/silk@8e48b8d),
and folds it into `silk-release` under `src/code.cloudfoundry.org/silk`.

Other changes worth mentioning:
- `scripts/test.sh` and `scripts/start-db-helper` taken from
  `cf-networking`, e.g. https://github.com/cloudfoundry/cf-networking-release/blob/develop/scripts/test.sh
    - the `silk` tests now require some databases to run
- removes scripts from the `silk` source repo
- Updates bosh packaging specs for the new pakage import path
- Consolidates `modules/modules.go` and `tools/tools.go` since they seem
  to do the same thing and we don't need to import the silk stuff

Addresses: cloudfoundry/silk#52

[#185149418](https://www.pivotaltracker.com/story/show/185149418)

Signed-off-by: Renee Chu <reneec@vmware.com>
@jrussett
Copy link
Contributor

jrussett commented Aug 3, 2023

This repo is ready to be archived and this issue is resolved.

This merged PR folded the silk src into silk-release: cloudfoundry/silk-release#89
This merged PR adds a deprecation notice to silk: #61

@jrussett jrussett closed this as completed Aug 3, 2023
@jrussett jrussett mentioned this issue Aug 3, 2023
jrussett added a commit to jrussett/community that referenced this issue Aug 4, 2023
We had originally setup silk in an enitre other repo with the intention
that it could be imported, used, and extended by other projects.
This never happened and now we have a separate repo for `silk` when it
is only used in `silk-release.

We have moved `silk` into `silk-release` and therefore `silk` is no
longer necessary.

More details:
- cloudfoundry/silk#52
- cloudfoundry/silk-release#89

[#185149418](https://www.pivotaltracker.com/story/show/185149418)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants