The class should equal, not the other way round #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: http://www.pivotaltracker.com/story/show/68803944. This repo is managed by the 'Runtime' team. |
Replaced numerous instances of `foo.should.class` with `foo.class.should`. As well as reading better, the latter version actually tests something.
|
Looks good to me. There might be a conversation here about whether we want to use @MarkKropf You want this test bug fix in the Runtime backlog? |
karlkfi
added a commit
that referenced
this pull request
Apr 3, 2014
The class should equal, not the other way round
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced various instances of
foo.should.classwithfoo.class.should. Aswell as reading better, the latter version actually tests something :).