Skip to content

Commit

Permalink
fix(pkg/egress/stats): resolve failing tests due to altered string re…
Browse files Browse the repository at this point in the history
…presentation of variable labels
  • Loading branch information
ctlong committed Oct 11, 2023
1 parent 5745872 commit 55423ee
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/pkg/egress/stats/prom_registry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,30 +20,30 @@ var _ = Describe("Prometheus Registry", func() {

It("registers the gauge when it's first gotten", func() {
gauge := toPromGauge(registry.Get("metric_name", "origin", "unit", nil))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`))

var registered prometheus.Gauge
Eventually(registerer.gauges).Should(Receive(&registered))

Expect(registered.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`))
Expect(registered.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`))
})

It("doesn't reregister gauges", func() {
gauge := toPromGauge(registry.Get("metric_name", "origin", "unit", nil))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`))

gauge = toPromGauge(registry.Get("metric_name", "origin", "unit", nil))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: []}`))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {unit="unit"}, variableLabels: {}}`))

Expect(registerer.gauges).To(HaveLen(1))
})

It("gauges with different tags are different gauges", func() {
gauge := toPromGauge(registry.Get("metric_name", "origin", "unit", map[string]string{"foo": "bar2"}))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar2",unit="unit"}, variableLabels: []}`))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar2",unit="unit"}, variableLabels: {}}`))

gauge = toPromGauge(registry.Get("metric_name", "origin", "unit", map[string]string{"foo": "bar"}))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar",unit="unit"}, variableLabels: []}`))
Expect(gauge.Desc().String()).To(Equal(`Desc{fqName: "metric_name", help: "vm metric", constLabels: {foo="bar",unit="unit"}, variableLabels: {}}`))

Expect(registerer.gauges).To(HaveLen(2))
})
Expand Down

0 comments on commit 55423ee

Please sign in to comment.