Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding issue #24

Closed
wants to merge 2 commits into from
Closed

encoding issue #24

wants to merge 2 commits into from

Conversation

strehle
Copy link
Member

@strehle strehle commented Jul 19, 2018

#23

@cfdreddbot
Copy link

Hey strehle!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/159169771

The labels on this github issue will be updated when the story is started.

* with new behaviour the client authentication is not set to header but to http body
* no Authorization
* check body for client_id and client_secret
@dbeneke
Copy link
Contributor

dbeneke commented Jun 27, 2019

Hello @strehle, we have begun working with the Go CLI and plan to accept your PR. We've created a story to represent the change: https://www.pivotaltracker.com/story/show/166970393

@dbeneke
Copy link
Contributor

dbeneke commented Jul 3, 2019

Hello @strehle - providing update. We have begun looking into the proposed change via the story mentioned above (#166970393). We intend to correct the issue, but are considering alternative implementation approaches as we review the CLI, but also underlying UAA implications.

@strehle
Copy link
Member Author

strehle commented Jul 4, 2019

Hello @dbeneke sure you can do it in like you want and if you fix UAA , great. The authorization via Header is in UAA not Oauth2 compliant but if uaa-cli uses the body to provide client id/credentials there is no issue with uaa, therefore this way.
However finally a credential flow with 'admin' and 'admin!secret' should work

@andrewedstrom
Copy link
Contributor

Client secret encoding has now been fixed in UAA and the CLI

@strehle strehle deleted the patch2 branch October 10, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants