Memcached as a Service Support #15

oza · 2012-01-01T08:01:04Z

Memcached is a de fact standard in-memory caching system.
This patch provides Cloud Foudnry with the provisioning, unprovisioning Memcached instances.

And, happy new year!

Signed-off-by: OZAWA Tsuyoshi ozawa.tsuyoshi@gmail.comDear Cloud Foundry contributor,

If you are reading this message, it means you submitted a pull request in the Cloud Foundry GitHub repository.

First of all, thanks! We really appreciate your participation.

Recently we made some changes in how we are verifying and reviewing open source contributions like yours. In addition, we changed the way we can expose our internal development in real-time. The changes are exciting, as they allow all our staff to collaborate seamlessly with you, which increases our mutual velocity and gives the community a bigger stake in our direction.

The Cloud Foundry team uses Gerrit, a code review tool that originated in the Android Open Source Project. We also use GitHub as an official mirror, though all pull requests are accepted via Gerrit.

Follow these steps to make a contribution to any of our open source repositories:

Complete our CLA Agreement for
individuals or
corporations.
Sign up for an account on our public Gerrit server at
http://reviews.cloudfoundry.org/.
Create and upload your public SSH key in your Gerrit account profile.

Set your name and email:

        git config --global user.name "Firstname Lastname"
        git config --global user.email "your_email@youremail.com"

Install our gerrit-cli gem:
```
        gem install gerrit-cli
```
Clone the Cloud Foundry repo:
Note: to clone the BOSH repo, or the Documentation repo, replace
vcap with bosh or oss-docs
```
        gerrit clone ssh://reviews.cloudfoundry.org:29418/vcap
        cd vcap
```
Make your changes, commit, and push to gerrit:
```
        git commit
        gerrit push
```

Once your commits are approved by our Continuous Integration Bot (CI Bot) as well as our engineering staff, return to the Gerrit interface and MERGE your changes. The merge will be replicated to GitHub automatically at https://github.com/cloudfoundry. If you get feedback on your submission, we recommend squashing your commit with the original change-id. See the squashing section here for more details: https://help.github.com/rebase.

igrigorik · 2012-01-01T15:26:28Z

memcached/lib/memcached_service/memcached_error.rb

+        # 31100 - 31199  Memcached-specific Error
+        # FIXME: This error code is paste from redis.
+        MEMCACHED_SAVE_INSTANCE_FAILED        = [31100, HTTP_INTERNAL, "Could not save instance: %s"]
+        MEMCACHED_DESTORY_INSTANCE_FAILED     = [31101, HTTP_INTERNAL, "Could not destroy instance: %s"]


Typo.. "DESTORY"

Thank you for your pointing out. I'll fix it.

krobertson · 2012-01-01T16:59:10Z

+1. I was pondering writing one as well.

It looks like there is still some commented out parts referring to redis, and I do agree some authentication would be good with like SASL.

oza · 2012-01-03T02:46:33Z

@yssk22r @krobertson Thank you for your advice. I'm going to support authentication with SASL and delete needless source code.

Memcached is a de fact standard in-memory caching system. This patch provides Cloud Foundry with the provisioning, unprovisioning Memcached instances. Some advices are given by: Ken Robertson <ken _at_ invalidlogic.com> Yohei Sasaki <yssk22 _at_ gmail.com> Ilya Grigorik <ilya _at_ igvita.com> Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

In PaaS environment, the authentication feature is required. This patch provides MaaS with SASL support of memcached. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

natea · 2012-01-24T17:01:45Z

Would be awesome to have memcached-as-a-service in CloudFoundry!

krobertson · 2012-01-24T17:09:22Z

Looks good! Definitely going to pull this into my code tree for PaaS.io! Will report back once I test it out.

leto · 2012-01-24T17:17:27Z

memcached/lib/memcached_service/memcached_node.rb

+    varz[:plan] = instance.plan
+    varz[:usage] = {}
+    varz[:usage][:max_memory] = instance.memory.to_f * 1024.0
+    # FIXME : get more detail information


Usage info will be necessary to merge this.

Fixed at https://github.com/nttcom/vcap-services/commit/1fff38ee132bf922726d76234f06952fa51b5661

oza · 2012-01-25T02:08:19Z

@krobertson @leto Thank you for your review! I'll fix the parts you pointed out, and commit to the memcached branch.

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

There are several fixes including: 1. avoiding instances leak. 2. authentication supports. 3. SASLAdmin's handling empty inputs. For more detail, Please see the source codes under the spec directory. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

oza · 2012-02-01T14:12:37Z

Now, all tasks are done. Please review the codes.

oza · 2012-02-02T23:44:06Z

@leto Thanks :-)

oza · 2012-02-03T07:06:56Z

@leto Please let me know if there are some points to fix to merge this patch.

krobertson · 2012-02-03T07:27:10Z

Sorry, haven't had a chance yet to review it some more but definitely will be.

leto · 2012-02-03T22:16:13Z

@oza we are transitioning to a new review system, if you are confident with the current patch, I can help push it through :) Have you ever used Gerrit?

oza · 2012-02-06T23:46:51Z

@krobertson I'm looking forward to your reviewing :-)

oza · 2012-02-06T23:50:23Z

@leto In fact, I've never used Gerrit. I'm going to learn it, however, if your new review system use it.

leto · 2012-02-08T00:30:05Z

@oza yes, we will continue to mirror to Github, but very soon we will have a public Gerrit instance so that external and internal developers will be working together and using the same workflow.

oza · 2012-02-08T05:00:07Z

@leto It's the great news for us! We're looking forward to joining to the exciting collaboration! Please let me know if it becomes available.

leto · 2012-02-09T03:31:35Z

@oza My highest priority is getting a a public Gerrit instance working. I will definitely let you know when it is close to ready :)

Also, it is our policy to leave copyright lines alone and instead add people/companies who contribute to https://github.com/cloudfoundry/vcap/blob/master/AUTHORS . Could you undo the changes to the copyright lines in this PR and create a new PR for vcap that adds yourself/NTT to AUTHORS?

Once that happens I can push this into our internal Gerrit so we can enjoy memcached support before the public Gerrit is ready :)

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

This commit includes 2 fixes: 1. Avoid memcached instance leak when running test cases. 2. Fixed some typo. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

Fixed to call start_instance() in enable_instance(). This change allows MaaS to work rebalancing correctly. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

krobertson · 2012-02-14T07:14:06Z

memcached/lib/memcached_service/memcached_node.rb

+    true
+  end
+
+  def enable_instance(service_credentials, binding_credentials_map = {})


I noticed that in disable_instance, there is a call to stop_instance, however in enable_instance, there is no call to start it again.

@krobertson Thank you for your review! This bug may cause unexpected case(especially when rebalancing), therefore I fixed at https://github.com/nttcom/vcap-services/commit/93a6a291881a4caacf5dda941838565286778e40

oza · 2012-02-14T16:30:41Z

@leto OK.

At first, I fixed the copyrights for merging at https://github.com/nttcom/vcap-services/commit/eff7956c08fff9931fe70230ac77b9b36e3cd960

Also, we'd like to add our name to the AUTHOR file, and should I send pull request to vcap itself instead of vcap-services?

leto · 2012-02-14T17:08:33Z

@oza, yes since vcap is the main repo and all others are submodules inside of vcap, we just keep one AUTHORS file.

oza · 2012-02-17T23:32:37Z

@leto We sent the pull request! Please check out: cloudfoundry-attic/vcap#185

oza · 2012-02-23T07:05:22Z

@leto Please notify me if there appear tasks which I should do or I can help.

oza · 2012-03-08T02:38:13Z

Wow, big changes came. We'll start to rebase to catch up vmware changes!
Please give me comments if there appear some fix points to merge. > commiters

igrigorik reviewed Jan 1, 2012
View reviewed changes

UEMURA Yuichi added 2 commits January 10, 2012 02:01

memcached_node: added SASL support.

a90f344

In PaaS environment, the authentication feature is required. This patch provides MaaS with SASL support of memcached. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

leto reviewed Jan 24, 2012
View reviewed changes

UEMURA Yuichi added 5 commits January 30, 2012 22:46

memcacehed_node: support to the stats of memcached instances

1fff38e

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

memcacehed_node: supported get_healthz

c4aba80

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

spec: added authentication tests.

3fef974

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

tests: Passed all test cases.

ee8325e

There are several fixes including: 1. avoiding instances leak. 2. authentication supports. 3. SASLAdmin's handling empty inputs. For more detail, Please see the source codes under the spec directory. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

memcached_node: deleted needless codes.

b07dbc8

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

copyright: fixed copyrights.

eff7956

Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

UEMURA Yuichi added 2 commits February 11, 2012 09:30

rspec: fixed typo and memcached instance leak

326ecf1

This commit includes 2 fixes: 1. Avoid memcached instance leak when running test cases. 2. Fixed some typo. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

memcached_node:start instance in enable_instance()

93a6a29

Fixed to call start_instance() in enable_instance(). This change allows MaaS to work rebalancing correctly. Signed-off-by: UEMURA Yuichi <y.uemura@ntt.com>

krobertson reviewed Feb 14, 2012
View reviewed changes

vmware-ac-gerrit closed this Apr 11, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Memcached as a Service Support #15

Memcached as a Service Support #15

oza commented Jan 1, 2012

igrigorik Jan 1, 2012

oza Jan 3, 2012

krobertson commented Jan 1, 2012

oza commented Jan 3, 2012

natea commented Jan 24, 2012

krobertson commented Jan 24, 2012

leto Jan 24, 2012

oza Feb 1, 2012

oza commented Jan 25, 2012

oza commented Feb 1, 2012

oza commented Feb 2, 2012

oza commented Feb 3, 2012

krobertson commented Feb 3, 2012

leto commented Feb 3, 2012

oza commented Feb 6, 2012

oza commented Feb 6, 2012

leto commented Feb 8, 2012

oza commented Feb 8, 2012

leto commented Feb 9, 2012

krobertson Feb 14, 2012

oza Feb 14, 2012

oza commented Feb 14, 2012

leto commented Feb 14, 2012

oza commented Feb 17, 2012

oza commented Feb 23, 2012

oza commented Mar 8, 2012

Memcached as a Service Support #15

Memcached as a Service Support #15

Conversation

oza commented Jan 1, 2012

igrigorik Jan 1, 2012

Choose a reason for hiding this comment

oza Jan 3, 2012

Choose a reason for hiding this comment

krobertson commented Jan 1, 2012

oza commented Jan 3, 2012

natea commented Jan 24, 2012

krobertson commented Jan 24, 2012

leto Jan 24, 2012

Choose a reason for hiding this comment

oza Feb 1, 2012

Choose a reason for hiding this comment

oza commented Jan 25, 2012

oza commented Feb 1, 2012

oza commented Feb 2, 2012

oza commented Feb 3, 2012

krobertson commented Feb 3, 2012

leto commented Feb 3, 2012

oza commented Feb 6, 2012

oza commented Feb 6, 2012

leto commented Feb 8, 2012

oza commented Feb 8, 2012

leto commented Feb 9, 2012

krobertson Feb 14, 2012

Choose a reason for hiding this comment

oza Feb 14, 2012

Choose a reason for hiding this comment

oza commented Feb 14, 2012

leto commented Feb 14, 2012

oza commented Feb 17, 2012

oza commented Feb 23, 2012

oza commented Mar 8, 2012