Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for go 1.18 #10

Merged
merged 2 commits into from Apr 13, 2022
Merged

fix for go 1.18 #10

merged 2 commits into from Apr 13, 2022

Conversation

Benjamintf1
Copy link
Member

Signed-off-by: Ben Fuller benjaminf@vmware.com
Co-authored-by: Ben Fuller benjaminf@vmware.com

Description

Please include a summary of the change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

- letting the pipeline do the actual golang bump and tests

- go tries to include git information but stemcells do not include git binary
  golang/go#51748

- go install instead of go get for installing in go 1.18

Signed-off-by: Ben Fuller <benjaminf@vmware.com>
Co-authored-by: Ben Fuller <benjaminf@vmware.com>
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

acrmp
acrmp previously approved these changes Apr 7, 2022
Copy link
Member

@mkocher mkocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for that 30 minute timeout but 🤷

@Benjamintf1 Benjamintf1 merged commit bc77e43 into main Apr 13, 2022
@Benjamintf1 Benjamintf1 deleted the go-1.18-prep branch April 13, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants