New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Restructure blank.hbs
#52
Conversation
Should the |
Great question @erikjung! I initially put the If this is an incorrect assumption, we can treat the What are your thoughts? If this isn't making sense, let me know and I can paste in some code examples. Thanks! :) |
@mrgerardorodriguez I'm not sure if it's correct or not anymore 😄 I'll defer to @tylersticka for an opinion on that placement of that |
I think (I actually wish |
Good point @tylersticka. I considered a similar change like this as well. It may actually not be too bad to make that change. That being said, perhaps we should make that a separate issue/task? |
I assumed it would be larger because it would require a change to the builder, but I'd love to be wrong about that.
Couldn't agree more! 👍 |
It does require a change in to the builder, but the way it was written, it doesn't seem like a huge task. :)
Was this a "LGTM" or a "I agree enthusiastically? I couldn't tell. 😁 |
Both, I guess? ¯_(ツ)_/¯ |
Per the comment here, this PR restructures the
blank.hbs
template and adds a blankfoot
block.cc: @tylersticka @erikjung