Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper margins are still inherited even when not included in the wrapper object's inheritStyles array #34

Closed
raddevon opened this issue Jun 16, 2015 · 4 comments · Fixed by #36
Assignees
Labels

Comments

@raddevon
Copy link

I've instantiated my hideShowPassword element not to inherit margin values (since they aren't inherited properly in Firefox. See issue #33.). However, the margins are still being specified on the wrapper element. Here's how I instantiated the element:

$('#password').hideShowPassword(false, true, {
    wrapper: {
      inheritStyles: ['display', 'verticalAlign']
    }
});
@tylersticka
Copy link
Member

This is a great catch. I forgot that jQuery.extend also applies to arrays.

@tylersticka
Copy link
Member

@raddevon This option is pretty gnarly as-is (we've got some open issues to streamline in the next version), but for now I think I've come up with a backwards-compatible quick-fix.

Could you give the version in the fix-inheritStyles branch a try for me to verify whether or not it resolves your issue?

@raddevon
Copy link
Author

@tylersticka Yes, this fixes it. Thank you for the quick fix!

@tylersticka
Copy link
Member

Thanks, @raddevon !

I'm gonna re-open this issue until it's merged into master, just in case any other users are having the problem before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants